Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1616#discussion_r73982987
  
    --- Diff: storm-core/src/jvm/org/apache/storm/executor/Executor.java ---
    @@ -204,8 +204,8 @@ public static Executor mkExecutor(Map workerData, 
List<Long> executorId, Map<Str
                     throw Utils.wrapInRuntime(ex);
                 }
             }
    -        executor.init(idToTask);
     
    +        executor.idToTask = idToTask;
    --- End diff --
    
    @HeartSaVioR Sorry, missed that. This code looks convoluted because it is 
ported from clojure. I am fine with that for now as these PRs are more about 
poring from clojure to Java. We can address these later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to