Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005642
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -233,6 +236,23 @@ public static void submitTopologyAs(String name, Map
stormConf, StormTopology to
if(topologyNameExists(conf, name, asUser)) {
throw new RuntimeException("Topology with name `" +
name + "` already exists on cluster");
}
+
+ // Dependency uploading only makes sense for distributed
mode
+ List<String> jarsBlobKeys;
+ List<String> artifactsBlobKeys;
+
+ DependencyUploader uploader = new DependencyUploader();
+ try {
+ uploader.init();
+ jarsBlobKeys =
uploadDependencyJarsToBlobStore(uploader);
+ artifactsBlobKeys =
uploadDependencyArtifactsToBlobStore(uploader);
--- End diff --
We can do that for jarsBlobKeys but can't do that for artifactsBlobKeys
since we share artifact blobs and we skip uploads if there're same artifact
uploaded before.
I'll address this for jarsBlobKeys. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
