[
https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413048#comment-15413048
]
ASF GitHub Bot commented on STORM-2016:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005642
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -233,6 +236,23 @@ public static void submitTopologyAs(String name, Map
stormConf, StormTopology to
if(topologyNameExists(conf, name, asUser)) {
throw new RuntimeException("Topology with name `" +
name + "` already exists on cluster");
}
+
+ // Dependency uploading only makes sense for distributed
mode
+ List<String> jarsBlobKeys;
+ List<String> artifactsBlobKeys;
+
+ DependencyUploader uploader = new DependencyUploader();
+ try {
+ uploader.init();
+ jarsBlobKeys =
uploadDependencyJarsToBlobStore(uploader);
+ artifactsBlobKeys =
uploadDependencyArtifactsToBlobStore(uploader);
--- End diff --
We can do that for jarsBlobKeys but can't do that for artifactsBlobKeys
since we share artifact blobs and we skip uploads if there're same artifact
uploaded before.
I'll address this for jarsBlobKeys. Thanks!
> Topology submission improvement: support adding local jars and maven
> artifacts on submission
> --------------------------------------------------------------------------------------------
>
> Key: STORM-2016
> URL: https://issues.apache.org/jira/browse/STORM-2016
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> This JIRA tracks actual work on below proposal / design document.
> https://cwiki.apache.org/confluence/display/STORM/A.+Design+doc%3A+adding+jars+and+maven+artifacts+at+submission
> Proposal discussion thread is here:
> http://mail-archives.apache.org/mod_mbox/storm-dev/201608.mbox/%3ccaf5108i9+tjanz0lgrktmkvqel7f+53k9uyzxct6zhsu6oh...@mail.gmail.com%3E
> Let's post on discussion thread if we have any opinions / ideas on this
> instead of leaving comments on this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
