Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1592
Hi @abellina,
this is a bit huge patch (even without thrift generated code) including
front-end change, so seems not easy for me to have time to review.
Before reviewing, two considerations from me:
1. Since recent RAS patches only applied to master branch, I'm not sure we
may want to apply RAS related improvement to 1.x as well. Would like to hear
opinions on @jerrypeng.
2. This changes nimbus.clj which is not ported yet, and it seems not small
- more than 300 lines changed only on nimbus.clj. I recently submitted a patch
which modifies nimbus.clj but it only changes 11 lines.
Btw, you said @kishorvpatil and @knusbaum, and @d2r already reviewed the
patch. Then why not review this again (and leave +1)? Reviewing internally is
no effect for Apache side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
