[
https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416389#comment-15416389
]
ASF GitHub Bot commented on STORM-1994:
---------------------------------------
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1592
Hi @abellina,
this is a bit huge patch (even without thrift generated code) including
front-end change, so seems not easy for me to have time to review.
Before reviewing, two considerations from me:
1. Since recent RAS patches only applied to master branch, I'm not sure we
may want to apply RAS related improvement to 1.x as well. Would like to hear
opinions on @jerrypeng.
2. This changes nimbus.clj which is not ported yet, and it seems not small
- more than 300 lines changed only on nimbus.clj. I recently submitted a patch
which modifies nimbus.clj but it only changes 11 lines.
Btw, you said @kishorvpatil and @knusbaum, and @d2r already reviewed the
patch. Then why not review this again (and leave +1)? Reviewing internally is
no effect for Apache side.
> Add table with per-topology & worker resource usage and components in (new)
> supervisor and topology pages
> ---------------------------------------------------------------------------------------------------------
>
> Key: STORM-1994
> URL: https://issues.apache.org/jira/browse/STORM-1994
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core, storm-ui
> Reporter: Alessandro Bellina
> Assignee: Alessandro Bellina
> Priority: Minor
> Attachments: supervisor_page_worker_table.png,
> topology_page_worker_table.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
