[
https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416515#comment-15416515
]
ASF GitHub Bot commented on STORM-2016:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74367004
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONFFILE = curr.pop()
+ elif token == "--jars":
+ jars_list.extend(curr.pop().split(','))
+ elif token == "--artifacts":
--- End diff --
This is already documented for `jar` so you can refer `help jar` to see
explanation. I've also documented to doc page.
The intention behind picking `artifacts` is that, I picked `packages` first
since this is what Spark already used, but realized why they use `packages` as
term is that they maintain spark-packages. So `artifacts` is the alternatives
for me.
Btw, the term `artifact` is used by Maven and Ivy, and Aether also uses
`Artifact` class to represent this.
> Topology submission improvement: support adding local jars and maven
> artifacts on submission
> --------------------------------------------------------------------------------------------
>
> Key: STORM-2016
> URL: https://issues.apache.org/jira/browse/STORM-2016
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> This JIRA tracks actual work on below proposal / design document.
> https://cwiki.apache.org/confluence/display/STORM/A.+Design+doc%3A+adding+jars+and+maven+artifacts+at+submission
> Proposal discussion thread is here:
> http://mail-archives.apache.org/mod_mbox/storm-dev/201608.mbox/%3ccaf5108i9+tjanz0lgrktmkvqel7f+53k9uyzxct6zhsu6oh...@mail.gmail.com%3E
> Let's post on discussion thread if we have any opinions / ideas on this
> instead of leaving comments on this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
