[
https://issues.apache.org/jira/browse/STORM-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423166#comment-15423166
]
ASF GitHub Bot commented on STORM-2039:
---------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1627#discussion_r74987767
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -743,7 +736,7 @@
(fn [& args]
(check-credentials-changed)
(if ((:storm-conf worker)
TOPOLOGY-BACKPRESSURE-ENABLE)
- (check-throttle-changed))))
+ (topology-backpressure-callback))))
--- End diff --
This feels like the wrong place for this.
For some reason the backpressure is tacked onto the credentials timer?
I know this was already the way it worked, but maybe there's a better place
for it now? I don't think it's good that the value of the
`task.credentials.poll.secs` config affects the frequency of backpressure
polling.
> Backpressure refactoring in worker and executor
> -----------------------------------------------
>
> Key: STORM-2039
> URL: https://issues.apache.org/jira/browse/STORM-2039
> Project: Apache Storm
> Issue Type: Story
> Reporter: Alessandro Bellina
> Assignee: Alessandro Bellina
> Priority: Minor
>
> * Use backpressure flags directly from disruptor queue instead of in the
> disruptor-backpressure-handlers in worker and executor
> * Other minor refactoring (eliminate redundant function)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
