Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1627#discussion_r74987767
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -743,7 +736,7 @@
(fn [& args]
(check-credentials-changed)
(if ((:storm-conf worker)
TOPOLOGY-BACKPRESSURE-ENABLE)
- (check-throttle-changed))))
+ (topology-backpressure-callback))))
--- End diff --
This feels like the wrong place for this.
For some reason the backpressure is tacked onto the credentials timer?
I know this was already the way it worked, but maybe there's a better place
for it now? I don't think it's good that the value of the
`task.credentials.poll.secs` config affects the frequency of backpressure
polling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
