[
https://issues.apache.org/jira/browse/STORM-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425764#comment-15425764
]
ASF GitHub Bot commented on STORM-1701:
---------------------------------------
Github user abellina commented on a diff in the pull request:
https://github.com/apache/storm/pull/1427#discussion_r75236698
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -415,23 +427,35 @@
;; 6. wait for workers launch
(log-debug "Syncing processes")
+ (log-debug "Keepers: " keepers)
+ (log-debug "Keep ports: " keep-ports)
+ (log-debug "Reassigned executors: " reassign-executors)
(log-debug "Assigned executors: " assigned-executors)
(log-debug "Allocated: " allocated)
(doseq [[id [state heartbeat]] allocated]
- (when (not= :valid state)
- (log-message
- "Shutting down and clearing state for id " id
- ". Current supervisor time: " now
- ". State: " state
- ", Heartbeat: " (pr-str heartbeat))
- (shutdown-worker supervisor id)))
+ (let
+ [worker-launchtime (:launchtime (@(:worker-launchtime-atom
supervisor) id))]
+ (when
+ (or
+ (and (not= :valid state)
+ (not= :not-started state))
+ (and (= :not-started state)
+ (or (nil? worker-launchtime)
+ (is-worker-launchtime-timed-out? now worker-launchtime
conf))))
+ (if (= :not-started state)
+ (log-message "Worker " id " failed to start"))
+ (log-message
+ "Shutting down and clearing state for id " id
+ ". Current supervisor time: " now
+ ". State: " state
+ ", Heartbeat: " (pr-str heartbeat))
+ (shutdown-worker supervisor id))))
(let [valid-new-worker-ids (get-valid-new-worker-ids conf supervisor
reassign-executors new-worker-ids)]
(ls-approved-workers! local-state
(merge
(select-keys (ls-approved-workers local-state)
(keys keepers))
- valid-new-worker-ids))
- (wait-for-workers-launch conf (keys valid-new-worker-ids)))))
--- End diff --
since we removed this, we should also remove the wait-for-workers-launch
private functions.
> Add simple JSON mapping to storm-hbase
> --------------------------------------
>
> Key: STORM-1701
> URL: https://issues.apache.org/jira/browse/STORM-1701
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hbase
> Reporter: Kristopher Kane
> Priority: Trivial
> Fix For: 2.0.0
>
>
> storm-hbase includes a way to map Storm fields to HBase CQs. This adds a
> similar ability where a single field contains a flat JSON and the keys map to
> CQs. The flat JSON must contain the row key.
> No intention of reverse mapping from HBaseLookUp as the existing HBaseMapper
> works well for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
