Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1649#discussion_r76279827
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -221,7 +224,22 @@ private boolean commit() {
}
private boolean poll() {
- return !waitingToEmit() && numUncommittedOffsets <
kafkaSpoutConfig.getMaxUncommittedOffsets();
+ final int maxUncommittedOffsets =
kafkaSpoutConfig.getMaxUncommittedOffsets();
+ final boolean poll = !waitingToEmit() && numUncommittedOffsets <
maxUncommittedOffsets;
+
+ if (!poll) {
+ final boolean isLoggable = logTimer.isExpiredResetOnTrue();
--- End diff --
Given that this is debug it won't print in normal op. If I turn on the
debug logging my expectations is to see the logs immediately. If I don't see
the messages than I will think that the debug log .
Either way I am ok with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
