Github user abellina commented on a diff in the pull request:
https://github.com/apache/storm/pull/1661#discussion_r76917059
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -1218,8 +1218,16 @@
(submit-local-topology nimbus "t1" {} topology)
;; Instead of sleeping until topology is scheduled,
rebalance topology so mk-assignments is called.
(.rebalance nimbus "t1" (doto (RebalanceOptions.)
(.set_wait_secs 0)))
- (Thread/sleep 1000)
- (.deactivate nimbus "t1")
+ ;; One second doesn't work on all systems. Try it five times
+ (loop [n 5]
+ (if-let [result (try
+ [(Thread/sleep 1000)
+ (.deactivate nimbus "t1")]
+ (catch Exception e
+ (when (zero? n)
+ (throw e))))]
+ (result 0)
--- End diff --
these should be aligned with (if-let +2 spaces from the opening parenthesis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
