Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r79571602
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -330,11 +328,9 @@ public void ack(Object messageId) {
public void fail(Object messageId) {
final KafkaSpoutMessageId msgId = (KafkaSpoutMessageId) messageId;
emitted.remove(msgId);
- if (msgId.numFails() < maxRetries) {
- msgId.incrementNumFails();
- retryService.schedule(msgId);
- } else { // limit to max number of retries
- LOG.debug("Reached maximum number of retries. Message [{}]
being marked as acked.", msgId);
+ msgId.incrementNumFails();
+ if (!retryService.schedule(msgId)) {
+ LOG.debug("Retry service indicated message should not be
retried. Message [{}] being marked as acked.", msgId);
--- End diff --
I would leave the message as it was before. "Reached maximum number of
retries. Message [{}] being marked as acked."
It adds overhead and it is irrelevant to be mentioning the retry service
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
