Github user srdo commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,25 @@
    + * Copyright 2016 The Apache Software Foundation.
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.kafka.spout;
    +import org.apache.kafka.common.serialization.Deserializer;
    + * @param <T> The type this deserializer deserializes to.
    + */
    +public interface SerializableDeserializer<T> extends Deserializer<T>, 
Serializable { 
    --- End diff --
    I thought it was nice to have, since setKey/ValueDeserializer in the 
builder implicitly requires the deserializer to be serializable. For example, 
if you try to set the standard Kafka StringDeserializer via those methods, 
you'll get a NotSerializableException when the topology is submitted to Storm, 
since they'll be set as fields on the final KafkaSpoutConfig field in 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to