Github user HeartSaVioR commented on a diff in the pull request:
    --- Diff: 
    @@ -72,10 +72,10 @@ private SupervisorInfo buildSupervisorInfo(Map<String, 
Object> conf, Supervisor
         private Map<String, Double> mkSupervisorCapacities(Map conf) {
             Map<String, Double> ret = new HashMap<String, Double>();
    -        Double mem = (double) 
    -        ret.put(Config.SUPERVISOR_MEMORY_CAPACITY_MB, mem);
    -        Double cpu = (double) (conf.get(Config.SUPERVISOR_CPU_CAPACITY));
    -        ret.put(Config.SUPERVISOR_CPU_CAPACITY, cpu);
    +        Number mem = (Number) 
    +        ret.put(Config.SUPERVISOR_MEMORY_CAPACITY_MB, mem.doubleValue());
    +        Number cpu = (Number) (conf.get(Config.SUPERVISOR_CPU_CAPACITY));
    --- End diff --
    Good point. Utils.getDouble() with default value would be safer.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to