Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1702#discussion_r80133790
  
    --- Diff: external/storm-eventhubs/pom.xml ---
    @@ -21,19 +21,19 @@
         <parent>
             <artifactId>storm</artifactId>
             <groupId>org.apache.storm</groupId>
    -        <version>1.0.3-SNAPSHOT</version>
    +        <version>1.0.2</version>
             <relativePath>../../pom.xml</relativePath>
         </parent>
         
         <artifactId>storm-eventhubs</artifactId>
    -    <version>1.0.3-SNAPSHOT</version>
    +    <version>1.0.2.1</version>
         <packaging>jar</packaging>
         <name>storm-eventhubs</name>
         <description>EventHubs Storm Spout</description>
     
         <properties>
             <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    -        <eventhubs.client.version>0.9.1</eventhubs.client.version>
    +        <eventhubs.client.version>1.0.1</eventhubs.client.version>
    --- End diff --
    
    IMHO it might be better to maintain the version of dependencies from the 
root pom.xml.
    Some modules do, and some modules don't, so it's not a mandatory but just 
food for thought.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to