Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1682#discussion_r80415924
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/ISqlTridentDataSource.java
---
@@ -17,14 +17,62 @@
*/
package org.apache.storm.sql.runtime;
-import org.apache.storm.trident.operation.Function;
-import org.apache.storm.trident.spout.IBatchSpout;
import org.apache.storm.trident.spout.ITridentDataSource;
+import org.apache.storm.trident.state.StateFactory;
+import org.apache.storm.trident.state.StateUpdater;
/**
* A ISqlTridentDataSource specifies how an external data source produces
and consumes data.
*/
public interface ISqlTridentDataSource {
+ /**
+ * SqlTridentConsumer is a data structure containing StateFactory and
StateUpdater for consuming tuples with State.
+ *
+ * Please note that StateFactory and StateUpdater should use same class
which implements State.
+ *
+ * @see org.apache.storm.trident.state.StateFactory
+ * @see org.apache.storm.trident.state.StateUpdater
+ */
+ class SqlTridentConsumer {
--- End diff --
Good point. Will address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
