Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1757
  
    @hmcl I agree that we should try to avoid duplicated code, but I also have 
seen that unneeded dependency makes dependency problem which is not directed 
from first level deps but transitive dependencies.
    If common codes are not related to kafka API, I'd rather to have common 
module between the twos, but if it's not (and even if it is), either way is OK 
to me. That was just my preference, and others could be thinking differently, 
and don't have strong opinion about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to