Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r87010659
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,19 +266,22 @@ private void doSeekRetriableTopicPartitions() {
if (offsetAndMeta != null) {
kafkaConsumer.seek(rtp, offsetAndMeta.offset() + 1); //
seek to the next offset that is ready to commit in next commit cycle
} else {
- kafkaConsumer.seekToEnd(toArrayList(rtp)); // Seek to
last committed offset
+ kafkaConsumer.seek(rtp, acked.get(rtp).committedOffset +
1); // Seek to last committed offset
}
}
}
// ======== emit =========
private void emit() {
- emitTupleIfNotEmitted(waitingToEmit.next());
- waitingToEmit.remove();
+ while(!emitTupleIfNotEmitted(waitingToEmit.next()) &&
waitingToEmit.hasNext()) {
--- End diff --
This is a performance improvement. emitTupleIfNotEmitted does what it
says. It may or may not emit a tuple. If it does not emit a tuple (because it
has already been emitted) then the spout will exit nextTuple() having emitted
nothing. In that case storm will sleep for 1 ms, even though waitingToEmit is
not necessarily empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
