I got one review done (Nimbus). Second one will likely have to wait until after the holiday as I will be out.
Nice work and thanks for pushing this forward. -Taylor > On Nov 21, 2016, at 10:46 AM, Bobby Evans <[email protected]> wrote: > > I have been pushing hard to get some of the last code moved over to java. > I currently have a pull request up for nimbus > https://github.com/apache/storm/pull/1744 > and another one based off of the nimbus pull request to move LocalCluster and > a lot of the other testing helper classes to java. > https://github.com/apache/storm/pull/1786 > I realize that this is kind of daunting. In aggregate it is over 8,000 lines > added and about 6,500 lines deleted. But any help people can give with > reviews would really be appreciated. > After these go in what is left is the ui, logviewer, a tiny amount in DRPC, > and the IsolationScheduler (which has a pull request up) for the main daemons > and then several tests. > Thanks, > Bobby
