Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1744#discussion_r89672804
  
    --- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
    @@ -242,11 +297,12 @@
             (.stop (:nimbus-thrift-server cluster-map))
             (catch Exception e (log-message "failed to stop thrift")))
           ))
    -  (.close (:state cluster-map))
    -  (.disconnect (:storm-cluster-state cluster-map))
    -  (doseq [s @(:supervisors cluster-map)]
    -    (.shutdownAllWorkers s nil ReadClusterState/THREAD_DUMP_ON_ERROR)
    -    (.close s))
    +  (if (:state cluster-map) (.close (:state cluster-map)))
    --- End diff --
    
    Can these keys be null in the cluster-map?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to