Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1783
@ambud
The code looks good except what @vesense commented.
Two things more to address:
1. It would be better to document new configurations. Without
documentation, end-users have no idea about added feature.
`external/storm-hbase/README.md` and `docs/storm-hbase.md`.
2. The code already uses JDK 8 API (Map.getOrDefault()), so can't get it as
it is for 1.x. Could you provide a new PR for 1.x branch?
It would be also great if you can test it (with Caffeine) on JRE7 (expected
to not work but we can document the precondition for JRE version) and JRE8
(expected to work).
cc. @ben-manes Is my expectation right?
Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
