Github user aandis commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90405070
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping is found
*/
V get(K key, V defaultValue);
+
+ /**
+ * @return all key value mappings as an unmodifiable map.
+ */
+ Map<K, V> getAll();
--- End diff --
> the issue with map is that you need to load the entire state into the map
before you can return
true. It makes sense for the interface to return an iterator. But I am not
sure of the implementation for say, `RedisKeyValueState`. Wouldn't you _need_
to load the entire state and preprocess them since there's
[deserialization](https://github.com/apache/storm/pull/1798/files#diff-2e47d8842f277cb12f6bddbe2b7f94f5R161)
involved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
