Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91359755
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -290,8 +285,13 @@ private boolean
emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
} else if (emitted.contains(msgId)) { // has been emitted and
it's pending ack or fail
LOG.trace("Tuple for record [{}] has already been emitted.
Skipping", record);
} else if (!retryService.isScheduled(msgId) ||
retryService.isReady(msgId)) { // not scheduled <=> never failed (i.e. never
emitted) or ready to be retried
- final List<Object> tuple = tuplesBuilder.buildTuple(record);
- kafkaSpoutStreams.emit(collector, tuple, msgId);
+ //TODO cache translator
--- End diff --
Can't we get rid of this TODO now by putting the translator in a field?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
