Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1835#discussion_r93781643
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/fetcher/KafkaRecordsFetchers.java
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.kafka.spout.internal.fetcher;
+
+import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
+import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.storm.kafka.spout.KafkaSpoutConfig;
+import org.apache.storm.kafka.spout.internal.Timer;
+import
org.apache.storm.kafka.spout.internal.partition.KafkaPartitionReader;
+import
org.apache.storm.kafka.spout.internal.partition.KafkaPartitionReaders;
+import org.apache.storm.task.TopologyContext;
+
+import java.util.concurrent.TimeUnit;
+
+public final class KafkaRecordsFetchers {
+ public static <K, V> KafkaRecordsFetcher<K, V> create(KafkaSpoutConfig
kafkaSpoutConfig,
+ KafkaConsumer<K,
V> consumer,
+ TopologyContext
context,
+
ConsumerRebalanceListener rebalanceListener) {
+ if (kafkaSpoutConfig.isManualPartitionAssignment()) {
+ int thisTaskIndex = context.getThisTaskIndex();
+ int totalTaskCount =
context.getComponentTasks(context.getThisComponentId()).size();
+ KafkaPartitionReader partitionReader =
KafkaPartitionReaders.create(
+ kafkaSpoutConfig.getKafkaSpoutStreams());
+ Timer partitionRefreshTimer = new Timer(500,
+ kafkaSpoutConfig.getPartitionRefreshPeriodMs(),
TimeUnit.MILLISECONDS);
+
+ ManualKafkaRecordsFetcher.PartitionAssignmentChangeListener
partitionAssignmentChangeListener = null;
+ if (rebalanceListener != null) {
--- End diff --
Won't this cause an NPE in ManualKafkaRecordsFetcher if the null case is
hit here? Why does it make sense to call create without a rebalance listener?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
