Github user vesense commented on the issue:

    https://github.com/apache/storm/pull/1359
  
    @ptgoetz @HeartSaVioR 
    Sorry for the delay. I have a lot of works to do at the end of the year.
    
    Thanks @HeartSaVioR for your help. I fixed this issue and pushed the 
commits again. Could you take a look again?
    
    
    >And could you please explain why 738baeb is added? Is there a bug in 
ported even scheduler?
    
    
https://github.com/apache/storm/commit/738baeb4d73bef035a3b165cc7a47d7cb3e544d4 
fixed a bug in `EvenScheduler`. The origin `EvenScheduler` allow requesting 
slots number bigger than available slots.
    
    ```
            reassign-slots (take (- total-slots-to-use (count alive-assigned))
                                 (sort-slots available-slots))
    ```
    
    According to clojure [`take`](https://clojuredocs.org/clojure.core/take):
    ```
    ;; returns all items if there are fewer than n
    (take 3 [1 2])
    ;;=> (1 2)
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to