Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1131
@jianbzhou thanks for your suggested fix and for the summary of changes. I
think that the best way to go about incorporating your changes is to create a
JIRA with summary along the lines "Kafka Spout Improvements/Fixes", and in the
description put the contents you pasted above. We can then create a pull
request with the suggested changes, and after it is reviewed, merge it into
master.
It may not be a non trivial merge because other users have already found
and fixed some bugs on the code, so likely your suggested fix has a different
base commit. Furthermore, one has to evaluate how to safely add your suggested
fixes on top of other fixes, which apparently are currently working. There is
also a [refactoring](https://github.com/apache/storm/pull/1832) of the spout
going on, which will also add more diffs, so we have to take everything into
consideration.
@jianbzhou I suggest the following: Can you please create the JIRA, or if
you don't have the permissions to do so, please let me know, and I can do it.
Then, you can either we can attach your patch to the JIRA, or create a pull
request with commit header that matches the JIRA summary. That will link the
pull request with the JIRA. If you decide to attach the patch, or even the file
with the java source to the JIRA, I will create the pull request.
@jianbzhou do you consider adopting a community version which may
potentially include only part of your fixes, and have other fixes committed by
other contributors. Or would you rather run in your production environment the
version that you currently have ?
@erikdw "you" would be "me" :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
