Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r94675511
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.scheduler.blacklist;
+
+import java.io.Serializable;
+import java.util.AbstractCollection;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.ConcurrentModificationException;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+
+public final class CircularBuffer<T extends Serializable> extends
AbstractCollection<T> implements Serializable {
+
+ // This is the largest capacity allowed by this implementation
+ private static final int MAX_CAPACITY = 1 << 30;
+
+ private int size = 0;
+ private int producerIndex = 0;
+ private int consumerIndex = 0;
+
+ private int capacity;
+
+ private Serializable[] underlying;
+
+ // Construct a buffer which has at least the specified capacity. If
+ // the value specified is a power of two then the buffer will be
+ // exactly the specified size. Otherwise the buffer will be the
+ // first power of two which is greater than the specified value.
+ public CircularBuffer(int capacity) {
+
+ if (capacity > MAX_CAPACITY) {
+ throw new IllegalArgumentException("Capacity greater than " +
+ "allowed");
+ }
+
+ this.capacity = capacity;
+ underlying = new Serializable[this.capacity];
+ }
+
+ // Constructor used by clone()
+ private CircularBuffer(CircularBuffer oldBuffer) {
+ size = oldBuffer.size;
+ producerIndex = oldBuffer.producerIndex;
+ consumerIndex = oldBuffer.consumerIndex;
+ capacity = oldBuffer.capacity;
+ //bitmask = oldBuffer.bitmask;
+ underlying = new Serializable[oldBuffer.underlying.length];
+ System.arraycopy(oldBuffer.underlying, 0, underlying, 0,
underlying.length);
+ }
+
+ private boolean isFull() {
+ return size == capacity;
+ }
+
+ public boolean add(Serializable obj) {
--- End diff --
Shouldn't this be
```public boolean add(T obj)```
Also if the is overriding an existing method we should use the `@Override`
annotation. This is for all of the methods here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
