GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1864
STORM-2176 Workers do not shutdown cleanly and worker hooks don't run when
a topology is killed
* increase supervisor.worker.shutdown.sleep.secs to let workers kill
themselves first even stuck
* disable shutdown hook for log4j2 to make sure logs are written after
shutdown is started
Please note that I didn't touch JVM's shutdown hook (leaving it to sleep 1
sec and halt) given that 1 sec looks enough if there's no issue on the worker.
In fact shutdown hook shouldn't take too much time.
Given that this is blocker for releasing 1.0.3 and 1.1.0, please review
soon so that we can go ahead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1864.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1864
----
commit 296828704431e9e481a470e1f2ee6ac8aa15c865
Author: Jungtaek Lim <[email protected]>
Date: 2017-01-06T08:21:05Z
STORM-2176 Workers do not shutdown cleanly and worker hooks don't run when
a topology is killed
* increase supervisor.worker.shutdown.sleep.secs to let workers kill
themselves first even stuck
* disable shutdown hook for log4j2 to make sure logs are written after
shutdown is started
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
