Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96763944
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTuple.java
---
@@ -15,22 +15,33 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.storm.kafka.spout;
-import org.apache.kafka.clients.consumer.ConsumerRecord;
-
-import java.util.List;
-
-public class KafkaSpoutTuplesBuilderWildcardTopics<K,V> implements
KafkaSpoutTuplesBuilder<K,V> {
- private KafkaSpoutTupleBuilder<K, V> tupleBuilder;
+import org.apache.storm.tuple.Values;
- public KafkaSpoutTuplesBuilderWildcardTopics(KafkaSpoutTupleBuilder<K,
V> tupleBuilder) {
- this.tupleBuilder = tupleBuilder;
+/**
+ * A list of Values in a tuple that can be routed
+ * to a given stream.
--- End diff --
If the `KafkaSpout` remains as is, I would suggest that we add a comment
here saying that the method
`org.apache.storm.kafka.spout.RecordTranslator#apply` must necessarily return
`KafkaTuple` if the user desires to write to multiple streams.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
