GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1895

    STORM-2323 Precondition for Leader Nimbus should check all topology blobs 
and also corresponding dependencies

    * change the precondition for leader Nimbus
    ** it should have all active topology blobs locally
    ** it should also have all corresponding dependency blobs locally
    ** corresponding dependencies will be extracted from topology codes (via 
getBlob)
    
    Since it tries to get blobs, probably leader listener can try to access 
other Nimbuses, and someone might think this is a bit dangerous.
    I also have other branch which only checks all active topology blobs, not 
corresponding dependency blobs, so please feel free to share your opinions.
    https://github.com/HeartSaVioR/storm/tree/STORM-2323-no-check-dependencies
    
    I'll create pull request for 1.x when we select one of these branch and 
review and ready to merge.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-2323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1895
    
----
commit c747a99b3344a7ede4da5898ed35a3d1e23b67fd
Author: Jungtaek Lim <[email protected]>
Date:   2017-01-25T04:16:44Z

    STORM-2323 Precondition for Leader Nimbus should check all topology blobs 
and also corresponding dependencies
    
    * change the precondition for leader Nimbus
    ** it should have all active topology blobs and corresponding dependencies 
locally

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to