Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1919#discussion_r100547080
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -314,15 +316,26 @@ private boolean
emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
boolean isScheduled = retryService.isScheduled(msgId);
if (!isScheduled || retryService.isReady(msgId)) { // not
scheduled <=> never failed (i.e. never emitted) or ready to be retried
final List<Object> tuple =
kafkaSpoutConfig.getTranslator().apply(record);
- if (tuple instanceof KafkaTuple) {
- collector.emit(((KafkaTuple)tuple).getStream(), tuple,
msgId);
- } else {
- collector.emit(tuple, msgId);
- }
- emitted.add(msgId);
- numUncommittedOffsets++;
- if (isScheduled) { // Was scheduled for retry, now being
re-emitted. Remove from schedule.
- retryService.remove(msgId);
+
+ if(consumerAutoCommitMode){
+ if (tuple instanceof KafkaTuple) {
--- End diff --
nit: indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
