I have attached updated source code of HDFSSpout for more reference. I have updated respective classes (not attached)
On 13/02/17, 10:02 PM, "Sachin Pasalkar" <[email protected]> wrote: >Hi, > >I was looking at storm hdfs spout code in 1.x branch, I found below >improvements can be made in below code. > > 1. Make org.apache.storm.hdfs.spout.AbstractFileReader as public so >that it can be used in generics. > 2. org.apache.storm.hdfs.spout.HdfsSpout requires readerType as >String. It will be great to have class<? extends AbstractFileReader> >readerType; So we will not use Class.forName at multiple places also it >will help in below point. > 3. HdfsSpout also needs to provide outFields which are declared as >constants in each reader(e.g.SequenceFileReader). We can have abstract >API AbstractFileReader in which return them to user to make it generic. > >Let me know your thoughts on this. > >Thanks, >Sachin
