Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1832#discussion_r100937812
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
    @@ -162,9 +204,13 @@ public static long deltaMs(long timeInMilliseconds) {
         }
         
         public static void advanceTime(long ms) {
    +        advanceTimeNanos(millisToNanos(ms));
    +    }
    +    
    +    public static void advanceTimeNanos(long nanos) {
             if (!simulating.get()) throw new IllegalStateException("Cannot 
simulate time unless in simulation mode");
    -        if (ms < 0) throw new IllegalArgumentException("advanceTime only 
accepts positive time as an argument");
    -        long newTime = simulatedCurrTimeMs.addAndGet(ms);
    +        if (nanos < 0) throw new IllegalArgumentException("advanceTime 
only accepts positive time as an argument");
    --- End diff --
    
    Can you please enclose the if statement in braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to