Github user priyank5485 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1978#discussion_r103527554
--- Diff:
external/storm-druid/src/main/java/org/apache/storm/druid/bolt/DruidBeamBolt.java
---
@@ -76,30 +77,33 @@ public void prepare(Map stormConf, TopologyContext
context, OutputCollector coll
@Override
public void execute(final Tuple tuple) {
- Future future =
tranquilizer.send((druidEventMapper.getEvent(tuple)));
- LOG.debug("Sent tuple : [{}]" , tuple);
+ if (TupleUtils.isTick(tuple)) {
--- End diff --
I agree with @satishd Right now, onTickTuple method is in abstract base
classes of different connectors and not even used. Taking Satish's approach is
a little more work since we will have to change the bolts that actually process
the tick tuples to separate out onProcess and onTickTuple logic. But i think
its worth. @dossett I did not exactly get the problem with exceptions. Can't we
have a catch all and rethrow as a RuntimeException?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
