Roshan, does this PR<https://github.com/apache/storm/pull/1831> and 
JIRA<https://issues.apache.org/jira/browse/STORM-2249> address the missing jars 
problem that you mentioned. I had created it in December 2016, but there is an 
ongoing discussion if we should indeed put the jars in the examples location or 
not.

On a different note, this storm-kafka-client/KafkaSpout 
PR<https://github.com/apache/storm/pull/1924> fixes a bug with the number of 
uncommitted offsets that is quite important. It is not a blocker, but it is 
quite critical. I am going to do one last pass reviewing today. It would be 
good if we could have this PR included with the release. Can anyone else review 
it as well ?

Thanks,
Hugo

On Mar 1, 2017, at 9:14 AM, P. Taylor Goetz 
<[email protected]<mailto:[email protected]>> wrote:

Yeah, I don’t think the file size is a killer/blocker. It’s largely due to 
shaded examples, etc. But it’s something to keep an eye on. Our binary releases 
shouldn’t have to be that big.

-Taylor

On Mar 1, 2017, at 12:09 PM, Roshan Naik 
<[email protected]<mailto:[email protected]>> wrote:

Have filed Jiras so for the 3 issues mentioned. Not sure if we need a JIRA for 
the file size getting bloated by that much.
Somebody better familiar with the matter may want to take about that?
-roshan


On 3/1/17, 8:13 AM, "P. Taylor Goetz" 
<[email protected]<mailto:[email protected]>> wrote:

  Thanks for bringing these up Roshan. Feel free to file JIRA tickets for these 
issues and assign the “Release Apache Storm 1.1.0” epic so they can be tracked 
for this release.

  -Taylor

On Mar 1, 2017, at 9:27 AM, Roshan Naik 
<[email protected]<mailto:[email protected]>> wrote:

Found these additional issues:



1- BUG: Even if topology.eventlogger.executors=0,  the event_logger bolt is 
instantiated … previously observed to cause ~10% degradation in perf even with 
logging disabled.

2- Missing Jars: The storm-*-examples jars are missing in the binary distro 
(other than a storm-pmml-examples.jar, storm-jms-examples.jar & 
flux-examples.jar).

3- Minor: HdfsSpoutTopology example has not been moved into storm-hdfs-examples 
from storm-starter



Another side observation …  v1.0.3 tar.gz downloadable was 190MB.   This v1.1.0 
tar.gz  downloadable is 297MB !! …. even though some of the example topologies 
didn’t make it.



-roshan







Reply via email to