Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1924#discussion_r104774094
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -329,11 +350,13 @@ private boolean 
emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
                         }
                     
                         emitted.add(msgId);
    -                    numUncommittedOffsets++;
                     
                         if (isScheduled) { // Was scheduled for retry, now 
being re-emitted. Remove from schedule.
                             retryService.remove(msgId);
    -                    }
    +                    } else {
    +                    //New tuple, increment the uncommitted offset counter
    --- End diff --
    
    Will fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to