Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1943#discussion_r109112216
--- Diff: storm-core/src/jvm/org/apache/storm/stats/CommonStats.java ---
@@ -23,10 +23,11 @@
import org.apache.storm.metric.api.IMetric;
import org.apache.storm.metric.internal.MultiCountStatAndMetric;
import org.apache.storm.metric.internal.MultiLatencyStatAndMetric;
+import org.apache.storm.utils.Utils;
@SuppressWarnings("unchecked")
public abstract class CommonStats {
- public static final int NUM_STAT_BUCKETS = 20;
+ public static final int NUM_STAT_BUCKETS =(int)
Utils.readStormConfig().get("num.stat.buckets");
--- End diff --
Could we find other approach, like passing that value from caller of
CommonStats?
I think we're reading storm config file again and again which looks
redundant, and even doing it for constant doesn't look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
