Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2036#discussion_r109283834
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -267,9 +267,11 @@
                                    ((:report-error <>) error)
                                    (catch Exception e
                                      (log-message "Error while reporting error 
to cluster, proceeding with shutdown")))
    -                             (if (or
    -                                    (exception-cause? InterruptedException 
error)
    -                                    (exception-cause? 
java.io.InterruptedIOException error))
    +                             (if (and
    --- End diff --
    
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/executor/error/ReportErrorAndDie.java#L41-L43
    
    According to current implementation for master branch, it should be
    
    ```
    (if (or
      (exception-cause? InterruptedException error)
      (and
        (exception-cause? java.io.InterruptedIOException error)
        (not (exception-cause? java.net.SocketTimeoutException error))))))
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to