Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1950#discussion_r109653583
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/common/commands/RedisCommands.java
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.redis.common.commands;
+
+import redis.clients.jedis.ScanParams;
+import redis.clients.jedis.ScanResult;
+
+import java.util.Map;
+
+/**
+ * This interface represents Jedis methods exhaustively which are used on
storm-redis.
+ *
+ * This is a workaround since Jedis and JedisCluster doesn't implement
same interface for binary type of methods,
+ * and unify binary methods and string methods into one interface.
+ */
+public interface RedisCommands {
+ // binary, common
+ Boolean exists(byte[] key);
+
+ Long del(byte[] key);
+
+ // binary, hash
+ byte[] hget(byte[] key, byte[] field);
+
+ String hmset(byte[] key, Map<byte[], byte[]> fieldValues);
+
+ Map<byte[], byte[]> hgetAll(byte[] key);
+
+ Long hdel(byte[] key, byte[]... fields);
+
+ ScanResult<Map.Entry<byte[], byte[]>> hscan(byte[] key, byte[] cursor,
ScanParams params);
+
+ // string, common
+ boolean exists(String key);
+
+ // string, hash
+ Map<String,String> hgetAll(String key);
+
+ String hmset(String key, Map<String, String> fieldValues);
--- End diff --
same as above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
