GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2044
[STORM-2454] the default returned value of this method which named
"isConsumerAutoCommitMode" in KafkaSpoutConfig.java should be false
[https://issues.apache.org/jira/browse/STORM-2454](url)
The configuration which named "enable.auto.commit" has been set to false
when we create a instance of KafkaSpoutConfig via the method of
"setDefaultsAndGetKafkaProps". And the logic of "isConsumerAutoCommitMode"
makes the returned value is "false",but the annotation is "true".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/storm
master_kafka_client_enableautocommit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2044
----
commit c2f2c227a34e6ef958875b090a289015652f6ed4
Author: liuzhaokun <[email protected]>
Date: 2017-04-05T09:03:28Z
[STORM-2454] the default returned value of this method which named
isConsumerAutoCommitMode in KafkaSpoutConfig.java should be false
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
