Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2029#discussion_r110038799
  
    --- Diff: examples/storm-elasticsearch-examples/pom.xml ---
    @@ -53,6 +54,11 @@
                 <artifactId>storm-elasticsearch</artifactId>
                 <version>${project.version}</version>
             </dependency>
    +        <dependency>
    +            <groupId>org.elasticsearch</groupId>
    +            <artifactId>elasticsearch</artifactId>
    +            <version>${elasticsearch.test.version}</version>
    --- End diff --
    
    can you add the scope to provided. This will allow users to pick their own 
version of elasticsearch2 while packaging the topology


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to