Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2053#discussion_r110830274
--- Diff: storm-client/src/jvm/org/apache/storm/windowing/Window.java ---
@@ -47,9 +47,17 @@
List<T> getExpired();
/**
- * If processing based on event time, returns the watermark time
otherwise the current timestamp.
+ * If processing based on event time, returns the window end time
based on watermark otherwise
+ * returns the current timestamp.
--- End diff --
Returning the current timestamp(at which this method is invoked) for non
event-timestamp scenarios does not look to be intuitive. Users may assume
`endTimeStamp` should return the timestamp at which the window is completed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
