Github user priyank5485 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2081#discussion_r113535108
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java
---
@@ -0,0 +1,250 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.common;
+
+import org.apache.commons.lang.StringUtils;
+import org.apache.commons.math3.util.Pair;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.Token;
+import org.apache.hadoop.security.token.TokenIdentifier;
+import org.apache.storm.security.INimbusCredentialPlugin;
+import org.apache.storm.security.auth.IAutoCredentials;
+import org.apache.storm.security.auth.ICredentialsRenewer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.security.auth.Subject;
+import javax.xml.bind.DatatypeConverter;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * The base class that for auto credential plugins that abstracts out some
of the common functionality.
+ */
+public abstract class AbstractAutoCreds implements IAutoCredentials,
ICredentialsRenewer, INimbusCredentialPlugin {
+ private static final Logger LOG =
LoggerFactory.getLogger(AbstractAutoCreds.class);
+ public static final String CONFIG_KEY_RESOURCES = "resources";
+
+ private List<String> configKeys = new ArrayList<>();
+ private Map<String, Map<String, Object>> configMap = new HashMap<>();
+
+ @Override
+ public void prepare(Map conf) {
+ doPrepare(conf);
+ String configKeyString = getConfigKeyString();
+ if (conf.containsKey(configKeyString)) {
+ configKeys.addAll((List<String>) conf.get(configKeyString));
+ for (String key : configKeys) {
+ if (conf.containsKey(key)) {
+ Map<String, Object> config = (Map<String, Object>)
conf.get(key);
+ configMap.put(key, config);
+ LOG.info("configKey = {}, config = {}", key, config);
+ }
+ }
+ }
+ }
+
+ @Override
+ public void populateCredentials(Map<String, String> credentials, Map
conf) {
+ try {
+ if (configKeys != null) {
+ Map<String, Object> updatedConf = updateConfigs(conf);
+ for (String configKey : configKeys) {
+ credentials.put(getCredentialKey(configKey),
+
DatatypeConverter.printBase64Binary(getHadoopCredentials(updatedConf,
configKey)));
+ }
+ } else {
+ credentials.put(getCredentialKey(StringUtils.EMPTY),
+
DatatypeConverter.printBase64Binary(getHadoopCredentials(conf)));
+ }
+ LOG.info("Tokens added to credentials map.");
+ } catch (Exception e) {
+ LOG.error("Could not populate credentials.", e);
+ }
+ }
+
+ private Map<String, Object> updateConfigs(Map topologyConf) {
+ Map<String, Object> res = new HashMap<>(topologyConf);
+ if (configKeys != null) {
+ for (String configKey : configKeys) {
+ if (!res.containsKey(configKey) &&
configMap.containsKey(configKey)) {
+ res.put(configKey, configMap.get(configKey));
+ }
+ }
+ }
+ return res;
+ }
+
+ @Override
+ public void renew(Map<String, String> credentials, Map topologyConf) {
+ doRenew(credentials, updateConfigs(topologyConf));
+ }
+
+ @Override
+ public void populateCredentials(Map<String, String> credentials) {
+ credentials.put(getCredentialKey(StringUtils.EMPTY),
+ DatatypeConverter.printBase64Binary("dummy place
holder".getBytes()));
+ }
+
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void populateSubject(Subject subject, Map<String, String>
credentials) {
+ addCredentialToSubject(subject, credentials);
+ addTokensToUGI(subject);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void updateSubject(Subject subject, Map<String, String>
credentials) {
+ addCredentialToSubject(subject, credentials);
+ addTokensToUGI(subject);
+ }
+
+ protected Set<Pair<String, Credentials>> getCredentials(Map<String,
String> credentials) {
+ Set<Pair<String, Credentials>> res = new HashSet<>();
+ if (configKeys != null) {
+ for (String configKey : configKeys) {
+ Credentials cred = doGetCredentials(credentials,
configKey);
+ if (cred != null) {
+ res.add(new Pair(configKey, cred));
+ }
+ }
+ } else {
+ Credentials cred = doGetCredentials(credentials,
StringUtils.EMPTY);
+ if (cred != null) {
+ res.add(new Pair(StringUtils.EMPTY, cred));
+ }
+ }
+ return res;
+ }
+
+ protected void fillHadoopConfiguration(Map topoConf, String configKey,
Configuration configuration) {
+ Map<String, Object> config = (Map<String, Object>)
topoConf.get(configKey);
+ LOG.info("TopoConf {}, got config {}, for configKey {}", topoConf,
config, configKey);
+ if (config != null) {
+ List<String> resourcesToLoad = new ArrayList<>();
+ for (Map.Entry<String, Object> entry : config.entrySet()) {
+ if (entry.getKey().equals(CONFIG_KEY_RESOURCES)) {
+ resourcesToLoad.addAll((List<String>)
entry.getValue());
+ } else {
+ configuration.set(entry.getKey(),
String.valueOf(entry.getValue()));
+ }
+ }
+ LOG.info("Resources to load {}", resourcesToLoad);
+ // add configs from resources like hdfs-site.xml
+ for (String pathStr : resourcesToLoad) {
+ configuration.addResource(new
Path(Paths.get(pathStr).toUri()));
+ }
+ }
+ LOG.info("Initializing UGI with config {}", configuration);
+ UserGroupInformation.setConfiguration(configuration);
--- End diff --
Will this work if tow hbase or hdfs bolts connecting to different clusters
are running in the same jvm? I think this was always the problem but
re-factoring in this PR aims to be able to connect to two different clusters.
Just checking if issue still exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
