GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2112
[STORM-2510] update checkstyle configuration to lower violations
1. Update from checkstyle-6.11.2 to checkstyle-7.7.
2. Tweak google_checks.xml from checkstyle-7.7 to have the following
changes that
are more inline with the way the storm code is written:
* 4 space indents instead of 2
* line-length limit is 120 instead of 100
3. Exclude the generated thrift code in storm-client from being checked.
4. Update all maxAllowedViolations to be in-sync with the current number of
violations, through use of the `update-all-pom-violations.bash` script that
is attached to STORM-2510.
NOTE: this also fixes STORM-2507.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erikdw/storm STORM-2510
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit 88cf6f7b418a6edb9ea32b66382261dd9e2570dd
Author: Erik Weathers <[email protected]>
Date: 2017-05-12T09:25:21Z
[STORM-2510] commit original unmodified google_checks.xml from
checkstyle-7.7
Just ran this command:
```
% curl -o storm-buildtools/storm_checkstyle.xml
https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-7.7/src/main/resources/google_checks.xml
```
commit 29c761908ec8305d36535c1d2e3d1c0c3d6c95d1
Author: Erik Weathers <[email protected]>
Date: 2017-05-12T09:27:10Z
[STORM-2510] update checkstyle configuration to lower violations
1. Update from checkstyle-6.11.2 to checkstyle-7.7.
2. Tweak google_checks.xml from checkstyle-7.7 to have the following
changes that
are more inline with the way the storm code is written:
* 4 space indents instead of 2
* line-length limit is 120 instead of 100
3. Exclude the generated thrift code in storm-client from being checked.
4. Update all maxAllowedViolations to be in-sync with the current number of
violations, through use of the `update-all-pom-violations.bash` script that
is attached to STORM-2510.
NOTE: this also fixes STORM-2507.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
