GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2117
STORM-2515: Fix most checkstyle violations in storm-kafka-client
Most of the remaining violations are a couple of methods missing javadocs
in the Trident code, which I don't feel familiar enough with Trident to write.
The last couple are because there's a method in KafkaSpoutConfig that contains
the SSL abbreviation. The rules only allow 2 capital letters in an
abbreviation. Renaming is a breaking change, but maybe this isn't an issue for
2.0?
I also added a commit making a few other changes I thought made sense. The
KafkaSpoutMessageId.getMetadata method was including the TopicPartition 3
times. The found variable in OffsetManager.findNextCommitOffset can be replaced
with a null check of nextCommitMsg. They are in a separate commit for now, so
this is easier to review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2515
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 57fcbbb21728a0b1ccbb41503914b7decc94fceb
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-05-15T19:47:04Z
STORM-2515: Fix most checkstyle violations in storm-kafka-client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
