Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
@jerrypeng The reason that particular piece of code was flagged was because
the logic and the return values were not consistent with each other.
returning -1 means less than (but the code was checking for a greater than).
As for me I was mostly looking at the tests and as all of the tests passed
(except for one that was not actually impacted by this change but another
change that was a really serious bug). If we need to switch this particular
part of the change back I am happy to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
