Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2090#discussion_r118845794
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TimeEvictionPolicy.java ---
@@ -41,8 +47,10 @@ public TimeEvictionPolicy(int windowLength) {
public Action evict(Event<T> event) {
long now = evictionContext == null ? System.currentTimeMillis() :
evictionContext.getReferenceTime();
long diff = now - event.getTimestamp();
- if (diff >= windowLength) {
+ if (diff >= (windowLength + delta)) {
return Action.EXPIRE;
+ } else if (diff < 0) { // do not process events beyond current ts
+ return Action.KEEP;
--- End diff --
Nitpick: I think the events are ordered when iterated over in
WindowManager, so returning Action.STOP might be marginally faster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
