Github user erikdw commented on the issue:

    https://github.com/apache/storm/pull/2117
  
    @srdo : my opinion runs contrary to others it seems.  For every breaking 
API change my team & company incur a bunch of coordination work.  We have many 
independent internal engineering teams that are entirely responsible for their 
own topology code, so if there is a breaking API change we need to work with 
each of them to get them to modify their code appropriately.
    
    Rather than breaking an API to adhere to a belatedly-applied code standard, 
we could take the approach of allowing explicit exemptions from the 
uppercase-in-identifier standard via annotations:
    * https://stackoverflow.com/a/22556386
    
    This would require another modification to the base checkstyle.xml file, 
since Google's defaults don't allow this explicit one-off suppression via 
annotations.
    
    If we don't have the stomach for using this suppression mechanism, then we 
should at the minimum backport the changed API identifier as an available 
method in every active storm version branch.  That will help minimize upgrade 
pains since people can make the changes when upgrading to 1.1.x, and not have 
to make this particular change when upgrading to 2.x.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to