GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2151
STORM-2542: Remove KafkaConsumer.subscribe API option, make
KafkaConsumer.assign the default
This builds on https://github.com/apache/storm/pull/2150, which is the
first commit in this. The third commit is purely class moves because the
kafka.spout package was getting a bit unwieldy.
This should only go on 2.x if it goes in at all.
Please see https://issues.apache.org/jira/browse/STORM-2542 for the
justification for why I believe we should make this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2151
----
commit 4b4529af8ae1a519ee1eee8432ad4c628aacfe78
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-06-05T12:59:19Z
STORM-2541: Fix storm-kafka-client manual subscription not being able to
start consuming
commit 771d0c8ffb8305a79306ab33e9e38946f7a414e9
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-06-05T12:59:19Z
STORM-2542: Remove storm-kafka-client KafkaConsumer.subscribe API option
commit 7032d485ec4a58a141ac5e92d69f9c748ab4b106
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-06-05T19:57:58Z
STORM-2542: Move some storm-kafka-client classes into their own packages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
