Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2113#discussion_r120646636
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java
---
@@ -52,18 +52,20 @@ public T setNumTasks(Number val) {
return addConfiguration(Config.TOPOLOGY_TASKS, val);
}
+ @SuppressWarnings("unchecked")
@Override
public T setMemoryLoad(Number onHeap) {
if (onHeap != null) {
--- End diff --
I agree but that is code that came before, and if we want to make that
change I would prefer to do it on a separate pull request, just so a breaking
change does not sneak in as part of review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
